Skip to content

Fix handling of paths containing spaces#99

Merged
jjohannes merged 4 commits intogradlex-org:mainfrom
koppor:fix-quotes
Feb 16, 2026
Merged

Fix handling of paths containing spaces#99
jjohannes merged 4 commits intogradlex-org:mainfrom
koppor:fix-quotes

Conversation

@koppor
Copy link
Contributor

@koppor koppor commented Feb 1, 2026

Follow-up to #85

Fixes

Error: Invalid Option: [dir/jabref/jabkit/build/libs/jabkit-100.0.0.jar:/tmp/a]

Blindly committing its late and not easy for me to integrate and test the build. Took me several hours to track down.

Reproduce:

  1. mkdir "/tmp/a dir/"
  2. cd "/tmp/a dir/"
  3. clone JabRef (I did git clone --recursive ~/git-repositories/jabref)
  4. cd jabref
  5. ./gradlew :jabkit:jpackage
Starting process 'command '/home/koppor/.gradle/jdks/amazon_com_inc_-25-amd64-linux.2/bin/jpackage''. Working directory: /tmp/a dir/jabref/jabkit Command: /home/koppor/.gradle/jdks/amazon_com_inc_-25-amd64-linux.2/bin/jpackage --type app-image --dest /tmp/a dir/jabref/jabkit/build/packages/ubuntu-22.04 --module org.jabref.jabkit --resource-dir /tmp/a dir/jabref/jabkit/build/tmp/jpackage/ubuntu-22.04/jpackage-resources --app-version 100.0.0 @/tmp/a dir/jabref/jabkit/build/tmp/jpackageUbuntu-22.04/args.txt --name jabkit --vendor JabRef --java-options -Xlog:disable --java-options --add-modules --java-options jdk.incubator.vector --java-options --enable-native-access=com.sun.jna,javafx.graphics,org.apache.lucene.core --java-options -XX:+UseSerialGC --java-options -XX:+UnlockExperimentalVMOptions --java-options -XX:+UseCompactObjectHeaders --jlink-options --ignore-signing-information --jlink-options --compress --jlink-options zip-6 --jlink-options --no-header-files --jlink-options --no-man-pages --jlink-options --bind-services --jlink-options --generate-cds-archive --add-modules jdk.incubator.vector
Successfully started process 'command '/home/koppor/.gradle/jdks/amazon_com_inc_-25-amd64-linux.2/bin/jpackage''
Error: Invalid Option: [dir/jabref/jabkit/build/libs/jabkit-100.0.0.jar:/tmp/a]

@testlens-app
Copy link

testlens-app bot commented Feb 1, 2026

✅ All tests passed ✅

🏷️ Commit: e3d8cb2
▶️ Tests: 310 executed
⚪️ Checks: 3/3 completed


Learn more about TestLens at testlens.app.

@jjohannes
Copy link
Member

Thanks. This is a regression that we introduces in 1.2. It is not only affecting Windows as the args file is now always used. I will do a patch release with this fix.

@jjohannes jjohannes merged commit c58f3da into gradlex-org:main Feb 16, 2026
3 checks passed
@jjohannes jjohannes added this to the 1.2.1 milestone Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments